Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the nightlies a little earlier #339

Closed
pmeier opened this issue Mar 29, 2022 · 5 comments
Closed

Build the nightlies a little earlier #339

pmeier opened this issue Mar 29, 2022 · 5 comments

Comments

@pmeier
Copy link
Contributor

pmeier commented Mar 29, 2022

torchdata builds the nightlies at 15:00 UTC+0

- cron: 00 15 * * *

and publishes them roughly 30 minutes later. The torchvision nightlies are build at 11:00 UTC+0 and also published roughly 30 minutes later.

This creates a 4 hour window where the torchvision tests that pull in torchdata run on outdated nightlies. For example see this CI run:

In the step "Install PyTorch from the nightly releases" we have

Installing collected packages: typing-extensions, torch
Successfully installed torch-1.12.0.dev20220329+cpu typing-extensions-4.1.1

Two steps later in "Install torchdata from nightly releases" we have

Installing collected packages: torch, torchdata
  Attempting uninstall: torch
    Found existing installation: torch 1.12.0.dev20220329+cpu
    Uninstalling torch-1.12.0.dev20220329+cpu:
      Successfully uninstalled torch-1.12.0.dev20220329+cpu
Successfully installed torch-1.12.0.dev20220328+cpu torchdata-0.4.0.dev20220328

Was the release schedule deliberately chosen this way? If not can we maybe move it to four hours earlier?

@ejguan
Copy link
Contributor

ejguan commented Mar 29, 2022

I can move it back to UTC 11 or 12.
I changed it yesterday because pytorch core sometimes take more time to update nightly release for a certain platforms. Then, for that certain platform, torchdata can't not build the release with right version of PyTorch for conda release.
Any suggestion on how to solve the problem of conda release?

@pmeier
Copy link
Contributor Author

pmeier commented Mar 29, 2022

torchvision should also be hit by the same issue, right? Unfortunately, I can't be much of a help, since our release workflow is different and hidden in https://our.internmc.facebook.com/intern/chronos/job/?jobname=torchvision%20nightly%20trigger&smc=chronos_gp_admin_client. See pytorch/vision#1449.

@ejguan
Copy link
Contributor

ejguan commented Mar 29, 2022

It seems true like the windows build of nightly torchvision https://anaconda.org/pytorch-nightly/torchvision/files.

I will change it to UTC 11

@ejguan
Copy link
Contributor

ejguan commented Mar 29, 2022

Fixed by #338

@ejguan ejguan closed this as completed Mar 29, 2022
@ejguan
Copy link
Contributor

ejguan commented Mar 29, 2022

For the problem I mentioned, by enabling nightly wheel and nightly conda release at different times, might resolve this issue. Add it to the tracker for Releng improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants