-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
traverse
is different from PyTorch core and broken
#435
Comments
Confirmed. We should send a PR to fix it ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Amongst other things, 0501f56 added the
torchdata/dataloader2/_graph_utils.py
module that implementstraverse
:data/torchdata/dataloader2/_graph_utils.py
Line 57 in 12cfaf8
Unfortunately, this differs from the one in PyTorch core. It is at least missing the patches that resolved #237. Trying to lint a datapipe that has circular references through the attributes (not a circular graph) fails again: https://github.com/pytorch/vision/runs/6551564325
Instead of re-implementing, could we maybe simply
from torch.utils.data.graph import traverse
to have a single source of truth?The text was updated successfully, but these errors were encountered: