Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if this typecast IO causing entire object to be read into the buffer #657

Closed
VitalyFedyunin opened this issue Jul 14, 2022 · 1 comment
Assignees

Comments

@VitalyFedyunin
Copy link
Contributor

yield url, StreamWrapper(BytesIO(self.handler.s3_read(url)))

CC @ejguan

@ejguan ejguan self-assigned this Jul 14, 2022
@ejguan
Copy link
Contributor

ejguan commented Aug 10, 2022

Using the same script from #500 to test the performance w/ or w/o BytesIO from S3FileLoader.

  • With BytesIO
S3FileLoader: Mean(23.807878967700006), STD(3.3510862470041345)
FSSpecFileOpener: Mean(2.4083272642999987), STD(0.3079321041894781)
  • Without BytesIO
S3FileLoader: Mean(25.671961921199994), STD(6.733909007381986)
FSSpecFileOpener: Mean(2.278061599999995), STD(0.31031518396637964)

It seems the performance is on parity and sometimes even worse than it with BytesIO. So, closing the issue for now unless more investigation on typecast is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants