Skip to content

Commit 25e8e54

Browse files
committed
More fix
1 parent dff9759 commit 25e8e54

File tree

3 files changed

+15
-20
lines changed

3 files changed

+15
-20
lines changed

.github/workflows/pull.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,7 @@ jobs:
351351
352352
# reinstall executorch
353353
bash ./install_executorch.sh --minimal
354+
pip list
354355
355356
# run python unittest
356357
python -m unittest examples.models.moshi.mimi.test_mimi

CMakeLists.txt

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -882,23 +882,14 @@ if(EXECUTORCH_BUILD_PYBIND)
882882
# torch/lib. Don't do this to APPLE, as it will error out on the following
883883
# error:
884884
#
885-
get_target_property(_rpath portable_lib INSTALL_RPATH)
886-
if(NOT _rpath)
887-
if(APPLE)
888-
set_target_properties(
889-
portable_lib PROPERTIES BUILD_RPATH "@loader_path/../../../torch/lib"
890-
INSTALL_RPATH "@loader_path/../../../torch/lib"
891-
)
892-
else()
893-
set_target_properties(
894-
portable_lib PROPERTIES BUILD_RPATH "$ORIGIN/../../../torch/lib"
895-
INSTALL_RPATH "$ORIGIN/../../../torch/lib"
896-
)
897-
endif()
885+
if(APPLE)
886+
# Skip setting @loader_path for APPLE, since it causes error like ld:
887+
# duplicate LC_RPATH '@loader_path' in '<site-packages>/torch/lib/
888+
# libtorch_cpu.dylib'
898889
else()
899-
message(
900-
STATUS
901-
"Skipping setting RPATH for portable_lib on Apple platforms, found: ${_rpath}"
890+
set_target_properties(
891+
portable_lib PROPERTIES BUILD_RPATH "$ORIGIN/../../../torch/lib"
892+
INSTALL_RPATH "$ORIGIN/../../../torch/lib"
902893
)
903894
endif()
904895

backends/cuda/runtime/cuda_backend.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,13 @@ class ET_EXPERIMENTAL CudaBackend final
7272
LOAD_SYMBOL(run, AOTInductorModelContainerRun);
7373
#undef LOAD_SYMBOL
7474

75-
handle->update_constants_from_blob =
76-
reinterpret_cast<AOTInductorModelUpdateConstantsFromBlobFunc>(
77-
get_function(so_handle, "AOTInductorModelUpdateConstantsFromBlob").get());
78-
if (handle->update_constants_from_blob == nullptr) {
75+
auto symbol_res =
76+
get_function(so_handle, "AOTInductorModelUpdateConstantsFromBlob");
77+
if (symbol_res.ok()) {
78+
handle->update_constants_from_blob =
79+
reinterpret_cast<AOTInductorModelUpdateConstantsFromBlobFunc>(
80+
symbol_res.get());
81+
} else {
7982
ET_LOG(
8083
Info,
8184
"Failed to load AOTInductorModelUpdateConstantsFromBlob. This .so is probably compiled on an old version of torch (<2.9.0)");

0 commit comments

Comments
 (0)