Skip to content

Commit 64fdebe

Browse files
authored
Run Android release job on ephemeral runners (#10190)
To summary the discussion with @kirklandsign, only repository secrets are accessible in a Nova linux job. However, GitHub warns against using such secrets on persistent self-hosted runners https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#hardening-for-self-hosted-runners. In this case, it's important to use a fresh ephemeral runner instead to make sure that nothing on the runner could steal these secrets. ### Testing https://github.com/pytorch/executorch/actions/runs/14465234621
1 parent 683869d commit 64fdebe

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Diff for: .github/workflows/android-release-artifacts.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ jobs:
4949
contents: read
5050
with:
5151
secrets-env: EXECUTORCH_MAVEN_SIGNING_KEYID EXECUTORCH_MAVEN_SIGNING_PASSWORD EXECUTORCH_MAVEN_CENTRAL_PASSWORD EXECUTORCH_MAVEN_CENTRAL_USERNAME EXECUTORCH_MAVEN_SIGNING_GPG_KEY_CONTENTS
52-
runner: linux.2xlarge
52+
# As this job has access to Maven credential, run this on a fresh ephemeral runner
53+
runner: ephemeral.linux.2xlarge
5354
docker-image: executorch-ubuntu-22.04-clang12-android
5455
submodules: 'recursive'
5556
ref: ${{ github.sha }}

0 commit comments

Comments
 (0)