Skip to content

Commit 6d11bf9

Browse files
committed
Try to fix loader_path issue
1 parent 1bcc04a commit 6d11bf9

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

CMakeLists.txt

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -99,27 +99,6 @@ announce_configured_options(CCACHE_PROGRAM)
9999

100100
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
101101

102-
# Setup RPATH. See
103-
# https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling
104-
# Use separate rpaths during build and install phases
105-
set(CMAKE_SKIP_BUILD_RPATH OFF)
106-
# Don't use the install-rpath during the build phase
107-
set(CMAKE_BUILD_WITH_INSTALL_RPATH ON)
108-
# Automatically add all linked folders that are NOT in the build directory to
109-
# the rpath (per library?)
110-
#
111-
# TODO: Doesn't work for us right now because we are not installing .so's into
112-
# the correct locations. For example we have libcustom_ops_aot_lib.so depending
113-
# on _portable_lib.so, which was eventually put under
114-
# <site-packages>/executorch/extension/pybindings/ but this rpath is not
115-
# automatically added because at build time it seems `portable_lib` is being
116-
# built under the same directory, so no extra rpath is being added. To properly
117-
# fix this we need to install `portable_lib` into the correct path.
118-
set(CMAKE_INSTALL_RPATH_USE_LINK_PATH ON)
119-
# ------------------------------ OPTIONS -------------------------------------
120-
# WARNING: Please don't add example specific options in this CMakeLists.txt.
121-
# Instead please use `find_package(executorch REQUIRED)` in the example
122-
# directory and add a new executable in the example `CMakeLists.txt`.
123102

124103
if(NOT EXECUTORCH_ENABLE_LOGGING)
125104
# Avoid pulling in the logging strings, which can be large. Note that this

0 commit comments

Comments
 (0)