Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Android extension with one-cmake-pass #6767

Open
kirklandsign opened this issue Nov 11, 2024 · 0 comments
Open

Build Android extension with one-cmake-pass #6767

kirklandsign opened this issue Nov 11, 2024 · 0 comments
Assignees
@kirklandsign
Labels
Android Android building and execution related. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@kirklandsign
Copy link
Contributor

🚀 The feature, motivation and pitch

Right now we need to build android extension with two cmake passes: one on main ET, one on android specific extension. See https://github.com/pytorch/executorch/blob/main/build/build_android_llm_demo.sh#L38-L81

Ideally, we could make one pass. This way, it is also easier to build the AAR.

Alternatives

No response

Additional context

No response

RFC (Optional)

No response
@kirklandsign kirklandsign added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module Android Android building and execution related. labels Nov 11, 2024
@kirklandsign kirklandsign self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirklandsign kirklandsign

Labels
Android Android building and execution related. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirklandsign