Skip to content

Commit e05c4bb

Browse files
committed
Change pre-commit config and CONTRIBUTING.md
- Update hook versions - Remove seed-isort-config - Add black profile to isort
1 parent f51320a commit e05c4bb

File tree

2 files changed

+12
-16
lines changed

2 files changed

+12
-16
lines changed

.pre-commit-config.yaml

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,32 @@
11
exclude: "^conda.recipe"
22
repos:
33
- repo: https://github.com/pre-commit/pre-commit-hooks
4-
rev: v2.3.0
4+
rev: v3.4.0
55
hooks:
66
- id: check-toml
77
- id: check-yaml
88
- id: end-of-file-fixer
99
- id: trailing-whitespace
1010

11-
- repo: https://github.com/prettier/pre-commit
12-
rev: main
11+
- repo: https://github.com/pre-commit/mirrors-prettier
12+
rev: v2.2.1
1313
hooks:
1414
- id: prettier
1515

16-
- repo: https://github.com/asottile/seed-isort-config
17-
rev: v1.9.4
18-
hooks:
19-
- id: seed-isort-config
20-
args: [--exclude=^((examples|docs)/.*)$]
21-
22-
- repo: https://github.com/timothycrosley/isort
23-
rev: 4.3.21-2
24-
hooks:
25-
- id: isort
26-
2716
- repo: https://github.com/python/black
2817
rev: 19.10b0
2918
hooks:
3019
- id: black
3120
language_version: python3.8
3221

22+
- repo: https://github.com/timothycrosley/isort
23+
rev: 5.7.0
24+
hooks:
25+
- id: isort
26+
args: ["--profile", "black"]
27+
3328
- repo: https://gitlab.com/pycqa/flake8
34-
rev: 3.7.7
29+
rev: 3.8.4
3530
hooks:
3631
- id: flake8
3732
args: [--append-config=tox.ini]

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ black manually to format files and commit them.
104104

105105
```bash
106106
# This should autoformat the files
107-
isort -rc .
108107
black .
108+
isort --profile black .
109109
# Run lint checking
110110
flake8 ignite/ tests/ examples/
111111
# If everything is OK, then commit
@@ -157,6 +157,7 @@ bash tests/run_cpu_tests.sh
157157
```
158158

159159
On Windows, distributed tests should be skipped
160+
160161
```bash
161162
SKIP_DISTRIB_TESTS=1 bash tests/run_cpu_tests.sh
162163
```

0 commit comments

Comments
 (0)