Anchor links for documentation are gone in 1.8.0 docs

[zou3519]

📚 Documentation

In 1.7.1 (notice the anchor on right):

In 1.8.0, the anchor doesn't show up anymore:
https://pytorch.org/docs/stable/autograd.html

cc @brianjo @mruberry

[brianjo]

I'll fix this. I just need to copy a couple of js files in.

[brianjo]

This should be working for stable/1.8.1 now.

[zou3519]

Discussed offline: the problem reoccurred so re-opening this issue. cc @mattip as well.

[brianjo]

I think the problem is that the vendor folder is missing from https://github.com/pytorch/pytorch.github.io/tree/site/docs/1.8.1/_static/js. (So they're not available in the stable folder on our master (gh-pages) branch. The missing folder can be found in the master folder: https://github.com/pytorch/pytorch.github.io/tree/site/docs/master/_static/js/vendor.

(I think the build is overwriting my gh-pages fix. I'll ty adding it to 1.8.1 on site.)

I tried a new fix here:
pytorch/pytorch.github.io#643

If that works in preview I'll merge it.

Edit: Fix seems to work:

https://6061e873ee736f0007f3a2d9--pytorch-dot-org-preview.netlify.app/docs/stable/autograd.html

[zou3519]

They're back! https://pytorch.org/docs/stable/autograd.html#torch.autograd.backward . Thanks @brianjo.

Should we leave this issue open? I think there is still a question of why the vendor folder doesn't get copied as a part of the docs build process that we should work out so we don't have to remember to copy it every time we do a release

[mattip]

The files do not exist in this repo. See PR #54961, which add them here. Should they be part of the theme instead?

Edit: The files are part of the theme

[brianjo]

Could it be that jekyll is causing problems? mpetrovich/stylemark#65. Do we need to add a .nojekyll to every new documentation release?

[brianjo]

The files do not exist in this repo. See PR #54961, which add them here. Should they be part of the theme instead?

They appear to be there: https://github.com/pytorch/pytorch_sphinx_theme/tree/master/pytorch_sphinx_theme/static/js/vendor

[brianjo]

Just created pytorch/pytorch.github.io#649 to try it out.

[brianjo]

Just created pytorch/pytorch.github.io#649 to try it out.

Just checked https://pytorch.org/docs/stable/autograd.html#torch.autograd.backward and the fix seems to be working. I'll close this for now. Please reopen if we have issues again. Thank you Richard! @zou3519