Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fonts #143

Open
adamjstewart opened this issue Sep 3, 2021 · 4 comments
Open

Missing fonts #143

adamjstewart opened this issue Sep 3, 2021 · 4 comments

Comments

@adamjstewart
Copy link

When I use this theme to render my project documentation on Read the Docs, I see many errors related to missing fonts, and the font doesn't get rendered correctly:

Screen Shot 2021-09-03 at 10 00 28 AM

Documentation source code can be found at: https://github.com/microsoft/torchgeo/tree/main/docs

Documentation can be found at: https://torchgeo.readthedocs.io/en/latest/

Am I supposed to ship these fonts myself?

@calebrob6

@adamjstewart
Copy link
Author

It seems these are shipped with pytorch_sphinx_theme under pytorch_sphinx_theme/static/fonts, not sure why they aren't being installed.

@adamjstewart
Copy link
Author

Hmm, they are being installed. Is the theme just looking in the wrong location for them?

@adamjstewart
Copy link
Author

adamjstewart commented Sep 3, 2021

If I move my requirements.txt to the docs directory and install pytorch_sphinx_theme in editable mode:

-e git+https://github.com/pytorch/pytorch_sphinx_theme#egg=pytorch_sphinx_theme

then the fonts get installed to the location that the theme expects (docs/_static/fonts). However, I don't think this should be necessary, and isn't necessary for other Sphinx themes.

@ain-soph
Copy link
Contributor

ain-soph commented Oct 4, 2021

The reason is that they don't upload codes to PYPI any longer, and the version on PYPI is 3 years ago and already out-of-date.

Codes in current repository (v0.0.24) are working fine, so it works if you clone the repo and build a binary wheel to install based on the current codes. But the current binary wheel file uploaded to Pypi (v0.0.19) doesn't contain the font files as package data.

Current codes has the package data claimed in setup.py that includes the font files:

'static/fonts/*.*',

If you install from github repo, you will have the up-to-date source codes and files including the font files. But if you simply use pip install pytorch-sphinx-theme, then you'll get the v0.0.19 which is uploaded 3 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants