-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read manifest inside _infer_with_profiler method #2480
Comments
Hi @pedrogengo Thanks for the proposal. I think it makes sense. Please feel free to send a PR. |
Tomorrow I will open a PR for that, tks for your quick reply |
@agunapal I opened a PR for this :) |
Thanks! Will review it tomorrow |
I decided to don't change anything in the |
🚀 The feature
Add a line to read the manifest file inside the method
_infer_with_profiler
ifself.manifest
is None (this can happen in cases the user overwrites theinitialize
method).If you think this makes sense, Im more than happy to contribute with it :)
Motivation, pitch
I'm working in some projects where we are overwriting the
initialize
method from base handler and we weren't creating theself.manifest
attribute on it. When I tried to run the torch profiler, the request broke becauseself.manifest
was None. IMO, as this attribute is used for other methods we should guarantee that we will have that or if the attribute is None we can read the file inside the_infer_with_profiler
method.This issue will happen to some examples too, like this one.
Alternatives
self.manifest
is None, read the file inside_infer_with_profiler
;self.manifest
defined in yourinitialize
method.Additional context
No response
The text was updated successfully, but these errors were encountered: