Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric auto-detection #2747

Closed
Tracked by #1492
lxning opened this issue Oct 30, 2023 · 0 comments · Fixed by #2769
Closed
Tracked by #1492

metric auto-detection #2747

lxning opened this issue Oct 30, 2023 · 0 comments · Fixed by #2769
Assignees

Comments

@lxning
Copy link
Collaborator

lxning commented Oct 30, 2023

🚀 The feature

Backend emits metrics via backend metrics APIs. Frontend is able to detect a metrics which is not defined in metrics.yaml and add this metrics in frontend metric cache. This feature workflow is

detect a new metrics name => extract dimension name, unit, type => add this metric definition in frontend cache.

Motivation, pitch

Metric refactor phase2 - support backend model metric auto-detection

In phase 1, TorchServe supports static metrics (ie. metrics defined in metric.yaml), publishes the metrics in either log format or prometheus format.

In phase 2, TorchServe will support the backend metrics not defined in metric.yaml. In this case, it causes perf overhead in frontend.

Alternatives

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants