Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] pytorch==2.5.0 breaks tensordict #1048

Closed
3 tasks done
egaznep opened this issue Oct 18, 2024 · 0 comments · Fixed by #1049
Closed
3 tasks done

[BUG] pytorch==2.5.0 breaks tensordict #1048

egaznep opened this issue Oct 18, 2024 · 0 comments · Fixed by #1049
Assignees
@vmoens
Labels
bug Something isn't working

Comments

@egaznep
Copy link
Contributor

egaznep commented Oct 18, 2024 •
edited
Loading

Describe the bug

tensordict/memmap.py:25: from torch.multiprocessing.reductions import ForkingPickler

but reductions.py does not import ForkingPickler anymore. (see pytorch/pytorch@abd16a8)

To reproduce

import tensordict

System info

(cannot import tensordict) 2.0.2 3.10.15 | packaged by conda-forge | (main, Oct 16 2024, 01:24:24) [GCC 13.3.0] linux 2.6.0.dev20241018

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have read the documentation (required)
  • I have provided a minimal working example to reproduce the bug (required)
@egaznep egaznep added the bug Something isn't working label Oct 18, 2024
This was referenced Oct 19, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmoens vmoens

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BugFix] Remove forkingpickler bhack/tensordict
2 participants
@egaznep @vmoens