Use our own index to seek more accurately when it is available #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change when the user asks us to seek to some timestamp T, we pass that timestamp down to FFMPEG.
However, we have noticed that sometimes FFMEPG seeks past that timestamp for certain files:
#179
https://trac.ffmpeg.org/ticket/11137
After this change if we have our own index, we use that to seek to the last keyframe before the target frame. This avoids the buggy behavior and seeks are accurate even for the H265 encoded videos.
Benchmarked this change and didn't find changes above the noise level.