Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torchsnapshot nightlies / torch nightlies are broken on python < 3.10 #169

Open
vmoens opened this issue Mar 7, 2024 · 0 comments · May be fixed by #170
Open

torchsnapshot nightlies / torch nightlies are broken on python < 3.10 #169

vmoens opened this issue Mar 7, 2024 · 0 comments · May be fixed by #170

Comments

@vmoens
Copy link

vmoens commented Mar 7, 2024

🐛 Describe the bug

As part of our CI we incorporate torchsnapshot nightlies tests.
Some signatures require python>3.9 as it appears here

The error reads

  File "/pytorch/rl/env/lib/python3.9/site-packages/torchsnapshot/io_preparers/sharded_tensor.py", line 200, in ShardedTensorIOPreparer
    ) -> Tuple[List[ReadReq], Future[ShardedTensor | torch.Tensor]]:
TypeError: unsupported operand type(s) for |: 'torch._C._TensorMeta' and 'torch._C._TensorMeta'

which occurs because https://github.com/pytorch/torchsnapshot/blob/main/torchsnapshot/io_preparers/sharded_tensor.py misses a

from __future__ import annotations

Versions

torch nightlies, python < 3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant