Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cosine LR scheduler with warmup from modules/ to training/ #1587

Closed
Tracked by #1747
ebsmothers opened this issue Sep 15, 2024 · 4 comments
Closed
Tracked by #1747

Move cosine LR scheduler with warmup from modules/ to training/ #1587

ebsmothers opened this issue Sep 15, 2024 · 4 comments
Labels
community help wanted We would love the community's help completing this issue

Comments

@ebsmothers
Copy link
Contributor

Hopefully not a controversial suggestion? I think training is the more natural place for LR schedulers (unless there is some dependency issue I'm missing).

@ebsmothers ebsmothers added the community help wanted We would love the community's help completing this issue label Sep 15, 2024
@krammnic
Copy link
Contributor

krammnic commented Oct 10, 2024

It seem to me that this affects on recipes, docs and 1 test. Will open PR now. I don't sure, should we save it in modules for few versions due to backward capability reasons

@ebsmothers
Copy link
Contributor Author

Thanks for creating the PR! I agree, let's keep the one in modules for now (but point everything to the version in training). Then add the deprecated flag saying that it will be removed in the 0.4 release and to use the one in training/ instead (example usage)

@krammnic
Copy link
Contributor

Thanks for creating the PR! I agree, let's keep the one in modules for now (but point everything to the version in training). Then add the deprecated flag saying that it will be removed in the 0.4 release and to use the one in training/ instead (example usage)

Ok, will update PR then

@joecummings
Copy link
Contributor

Closed by #1801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community help wanted We would love the community's help completing this issue
Projects
None yet
Development

No branches or pull requests

3 participants