Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM dataset docs nits #1858

Closed
SalmanMohammadi opened this issue Oct 17, 2024 · 0 comments · Fixed by #2067
Closed

MM dataset docs nits #1858

SalmanMohammadi opened this issue Oct 17, 2024 · 0 comments · Fixed by #2067
Assignees
@pbontrager
Labels
documentation Improvements or additions to documentation

Comments

@SalmanMohammadi
Copy link
Collaborator

SalmanMohammadi commented Oct 17, 2024 •
edited
Loading

  • Remove a floating TODO to point to flamingo transform (actually, the same for Llava instruct).
  • Multimodal_chat_dataset docstring example still uses FlamingoTransform.
  • Describe in TheCauldronToMessages that the "image" key in column_map can be used.
  • ShareGPTToMessages does not sufficiently describe how to use with MM.
  • llava_instruct_dataset has a packed parameter even though we don't support packing for MM. Let's just remove it.
@SalmanMohammadi SalmanMohammadi added the documentation Improvements or additions to documentation label Oct 17, 2024
@pbontrager pbontrager self-assigned this Oct 18, 2024
@SalmanMohammadi SalmanMohammadi mentioned this issue Nov 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbontrager pbontrager

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MM Docs nits SalmanMohammadi/torchtune
2 participants
@pbontrager @SalmanMohammadi