Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evals are currently broken #464

Closed
rohan-varma opened this issue Mar 7, 2024 · 1 comment
Closed

Evals are currently broken #464

rohan-varma opened this issue Mar 7, 2024 · 1 comment
Assignees
@rohan-varma
Labels
bug Something isn't working startup error testing

Comments

@rohan-varma
Copy link
Member

The checked in eval script is not backed by CI at the moment, https://github.com/pytorch-labs/torchtune/pull/406/files broke it as it removed some APIs such as list_models, get_model etc that evals use.
@rohan-varma rohan-varma added bug Something isn't working testing startup error labels Mar 7, 2024
@rohan-varma rohan-varma self-assigned this Mar 7, 2024
@rohan-varma rohan-varma mentioned this issue Mar 7, 2024
Closed
@joecummings
Copy link
Contributor

Completed by #549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohan-varma rohan-varma

Labels
bug Something isn't working startup error testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rohan-varma @joecummings