Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

beam search #680

Open
Oktai15 opened this issue Dec 25, 2019 · 2 comments
Open

beam search #680

Oktai15 opened this issue Dec 25, 2019 · 2 comments

Comments

@Oktai15
Copy link

Oktai15 commented Dec 25, 2019

According to README:

Currently, we export components (encoder, decoder) to Caffe2 separately and beam search is implemented in C++. In the near future, we will be able to export the beam search as well. We also plan to add export support to more models.

Where can I find this C++ code or exportable (jit) beam search already in repo?

@cndn
Copy link
Contributor

cndn commented Dec 27, 2019

Sorry README is out-of-date. We already have BeamSearch class fully scripted in ensemble_export.py. Also Pytorch->ONNX->Caffe2 export path as mentioned in README is not supported now. We are switching to TorchScript export so you can call save_to_pytorch() in BeamSearch class to get an exported model.

@Oktai15
Copy link
Author

Oktai15 commented Dec 30, 2019

@cndn I see that pytorch-translate has version of BeamSearchV2 that have new improvements, but it doesn't support char source. Why?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants