[fbsync] Use --no-implicit-optional for type checking (#6413)

Summary:
* Use --no-implicit-optional for type checking

This is needed for PEP 484 compliant type checking (as of 2018).
mypy will change its defaults soon.

See python/mypy#9091

* forcing CI rerun

Reviewed By: datumbox

Differential Revision: D38824221

fbshipit-source-id: 2f786faadaedd7eaf0dd2147a9c575d1d86c9db0

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Author: 2 people

mypy.ini

@@ -4,6 +4,7 @@ files = torchvision
 show_error_codes = True
 pretty = True
 allow_redefinition = True
+no_implicit_optional = True
 warn_redundant_casts = True
 
 [mypy-torchvision.prototype.features.*]

torchvision/datasets/utils.py

@@ -458,7 +458,7 @@ def iterable_to_str(iterable: Iterable) -> str:
 def verify_str_arg(
     value: T,
     arg: Optional[str] = None,
-    valid_values: Iterable[T] = None,
+    valid_values: Optional[Iterable[T]] = None,
     custom_msg: Optional[str] = None,
 ) -> T:
     if not isinstance(value, torch._six.string_classes):