Skip to content

standardize dataset naming conventions #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirk86 opened this issue Sep 7, 2019 · 2 comments
Open

standardize dataset naming conventions #1305

kirk86 opened this issue Sep 7, 2019 · 2 comments

Comments

@kirk86
Copy link

kirk86 commented Sep 7, 2019

Please standardize at least the naming convention for all datasets when using DataLoader so that data are in loader.dataset.data and labels in loader.dataset.targets.
MWE:

loader_cifar = torch.utils.DataLoader("CIFAR10")
loader_cifar.dataset.data <-- contains the data
loader_cifar.dataset.targets <-- contains targets

loader_svhn = torch.utils.DataLoader("SVHN")
loader_svhn.dataset.data <-- contains the data
loader_svhn.dataset.labels <-- contains targets

This can be really confusing and error prone when developing code to run on multiple datasets.

cc @pmeier

@pmeier
Copy link
Collaborator

pmeier commented Sep 7, 2019

See #1080.

@kirk86
Copy link
Author

kirk86 commented Sep 7, 2019

Thanks, where are we with that? Any progress?
I've already added my two cents on that issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants