Skip to content

Improve utilites #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
oke-aditya opened this issue Feb 9, 2021 · 0 comments · Fixed by #3594
Closed
5 tasks done

Improve utilites #3364

oke-aditya opened this issue Feb 9, 2021 · 0 comments · Fixed by #3594

Comments

@oke-aditya
Copy link
Contributor

oke-aditya commented Feb 9, 2021

🚀 Feature

Our utility section just got a revamp! But there are some rough edges.

We added utilities to plot bounding boxes #2556 #2785 and utility to plot semantic segmentation masks #3272 #3330

Pitch

  • Add Test to check modifications are not in place. Simply assert if the initial image is the same as final after calling the util.
  • For all the utils add docs for Returns. In other docs for boxes.py E.g. nms We specify what it returns.
  • Overall code coverage of utils is quite low ~60, bump it up! Most are simple error checks and corner cases.
  • Add GitHub gist notebook for all plotting utils. Show a demonstration with torchvision models
  • Make the current segmentation utility work for single-channel image. Since mask-rcnn returns masks in single-channel outputs, this utility if extended will serve its job too.

Additional context

The last point should be discussed in a bit detail. Others look straightforward to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants