Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pngs with more than 8 bits #4107

Closed
NicolasHug opened this issue Jun 24, 2021 · 3 comments · Fixed by #4657
Closed

Support pngs with more than 8 bits #4107

NicolasHug opened this issue Jun 24, 2021 · 3 comments · Fixed by #4657

Comments

@NicolasHug
Copy link
Member

We support 1-bit pngs and 8-bits pngs, but we explicitly don't support 16-bits or 32-bits pngs (see #3613). It would be good to add support for those images.

@saswatpp
Copy link
Contributor

saswatpp commented Sep 2, 2021

Hi @NicolasHug Can I take this issue/enhancement? I hope this is not super urgent because I have to take time to understand internals before coming up with a design and a PR.

@NicolasHug
Copy link
Member Author

Thanks for your interest in this issue @saswatpp , it isn't super urgent, don't worry.

I'm not sure how difficult this one could be though, it's the kind of thing that can either be a matter of adding a few lines of code... or a few hundreds. However note that it will definitely involve some C++ coding, so it's good to have prior experience with C++.

Perhaps @andfoy has a better idea of the expected difficulty here?

@NicolasHug
Copy link
Member Author

@saswatpp just FYI I started working on this in #4657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants