Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't push spuriously numbered git tags #7650

Closed
h-vetinari opened this issue Jun 2, 2023 · 6 comments
Closed

Please don't push spuriously numbered git tags #7650

h-vetinari opened this issue Jun 2, 2023 · 6 comments

Comments

@h-vetinari
Copy link

Hi!

I help package various pytorch (and many other) packages in conda-forge. We rely on an automated bot to scrape the various repositories to check if new versions have been published, and tags like ciflow/default/5009 make this much more difficult, because the bot now thinks that a version "5009" of torchvision has been published, and then fails with:

The recipe did not change in the version migration, a URL did not hash, or there is jinja2 syntax the bot cannot handle!

Please check the URLs in your recipe with version '5009' to make sure they exist!

We also found the following errors:

 - could not hash URL template 'https://github.com/pytorch/vision/archive/v{{ version }}.tar.gz'

Of course, one could argue that the bot should be(come) smarter, but OTOH, that tag looks pretty spurious AFAICT. Is it really necessary to publish such tags on the main repo? Could you remove them and avoid that going forward? That would be amazing (otherwise we potentially fall far behind with updates, because it takes a human to figure out why the bot has stopped).

CC @NicolasHug

@NicolasHug
Copy link
Member

CC @pmeier any idea what these tags are?

@pmeier
Copy link
Contributor

pmeier commented Jun 2, 2023

They are coming a mechanism that is used in PyTorch core to conditionally run CI jobs on PRs. Without going into too much details, whenever you put a ciflow/* label onto a PR, e.g. ciflow/default on #5009, a bot pushes the corresponding tag to the repo, which ultimately serves as CI trigger. That is quite convoluted, but was the best solution that was found to conditionally trigger CI jobs and have them placed together with the regular ones inside the GH UI.

That being said, there are two things wrong here:

  1. The bot should also delete these tags again after the PR is closed or merged, but that doesn't seem to be the case here. Works as expected. All tags corresponded to open PRs.
  2. We are not using this system (yet).

For now we can safely delete these tags. In the future, if move forward with more conditional CI, e.g. #7507, the conda-forge bot might need to be fixed.

@pmeier
Copy link
Contributor

pmeier commented Jun 2, 2023

Seems the labels come from a previous test with the bot:

Screenshot from 2023-06-02 10-51-54

@pmeier
Copy link
Contributor

pmeier commented Jun 2, 2023

Deletion mechanism seems to work. I've removed the label from #5009 and the tag is gone now: https://github.com/pytorch/vision/releases/tag/ciflow%2Fdefault%2F5009

@pmeier
Copy link
Contributor

pmeier commented Jun 2, 2023

I've removed the label from all the open PRs that still had them. All corresponding tags should be gone now.

@pmeier
Copy link
Contributor

pmeier commented Jun 2, 2023

Closing this for now, since as of now there are no more of the tags in question. However, they might get a comeback if we need this for our CI infrastructure. @h-vetinari I'll give you a ping in that case.

@pmeier pmeier closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants