Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.12 CI jobs #8293

Closed
NicolasHug opened this issue Mar 4, 2024 · 3 comments
Closed

Add 3.12 CI jobs #8293

NicolasHug opened this issue Mar 4, 2024 · 3 comments

Comments

@NicolasHug
Copy link
Member

The next version should support 3.12 so we should make sure to cover that in our CI jobs.

Let's also merge #8119 and #8280

Just delaying this a bit until #8292 is managed.

Note: 3.8 removal won't happen before 2.4 pytorch/pytorch#120718

@NicolasHug NicolasHug changed the title Add 3.12 CI job Add 3.12 CI jobs Mar 4, 2024
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 4, 2024

Very excited about this.

I'm not sure if the pytorch deprecation warnings were handled by pytorch itself, but I wanted to point to an obscur error message that we "addressed" at conda-forge.

the AST in python 3.12 issues a few warnings to pytorch, so with the strict warning catching of some of the tests, the test suite doesn't pass with 3.12.

We relaxed them with a small patch

https://github.com/conda-forge/torchvision-feedstock/blob/b88453f2b521986e5f3d52ac4e626ccf94046adb/recipe/ignore_python312_deprecation_warnings.patch

diff --git a/test/test_transforms_v2_refactored.py b/test/test_transforms_v2_refactored.py
index e18beb35a4..142e3f2d43 100644
--- a/test/test_transforms_v2_refactored.py
+++ b/test/test_transforms_v2_refactored.py
@@ -416,7 +416,10 @@ def reference_affine_bounding_boxes_helper(bounding_boxes, *, affine_matrix, new
 
 
 # turns all warnings into errors for this module
-pytestmark = pytest.mark.filterwarnings("error")
+pytestmark = [
+    pytest.mark.filterwarnings("error"),
+    pytest.mark.filterwarnings("ignore::DeprecationWarning"),
+]
 
 
 class TestResize:

@NicolasHug
Copy link
Member Author

Thanks a lot for the headsup @hmaarrfk , I'm observing the same issue in #8299. Let's see if ffd7bd5 can address that.

@NicolasHug
Copy link
Member Author

All done in #8299, we can close this. Thanks @hmaarrfk for the PRs and help with the warnings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants