Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test using real image few flaky models #7050

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified test/expect/ModelTester.test_resnet101_expect.pkl
Binary file not shown.
Binary file modified test/expect/ModelTester.test_resnet34_expect.pkl
Binary file not shown.
26 changes: 21 additions & 5 deletions test/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,13 @@ def _get_image(input_shape, real_image, device):

# make the image square
img = img.crop((0, 0, original_width, original_width))
img = img.resize(input_shape[1:3])
img = img.resize(input_shape[-2:])

convert_tensor = transforms.ToTensor()
image = convert_tensor(img)
if len(input_shape) == 4:
# Add extra batch dimension
image = image.unsqueeze(0)
assert tuple(image.size()) == input_shape
return image.to(device=device)

Expand Down Expand Up @@ -142,7 +145,7 @@ def _assert_expected(output, name, prec=None, atol=None, rtol=None):

if ACCEPT:
filename = {os.path.basename(expected_file)}
print(f"Accepting updated output for {filename}:\n\n{output}")
# print(f"Accepting updated output for {filename}:\n\n{output}")
torch.save(output, expected_file)
MAX_PICKLE_SIZE = 50 * 1000 # 50 KB
binary_size = os.path.getsize(expected_file)
Expand Down Expand Up @@ -283,6 +286,8 @@ def _check_input_backprop(model, inputs):
# the _test_*_model methods.
_model_params = {
"inception_v3": {"input_shape": (1, 3, 299, 299), "init_weights": True},
"resnet101": {"real_image": True, "pretrained_weight": True, "num_classes": 1000, "num_expect": 50},
"resnet34": {"real_image": True, "pretrained_weight": True, "num_classes": 1000, "num_expect": 50},
"retinanet_resnet50_fpn": {
"num_classes": 20,
"score_thresh": 0.01,
Expand Down Expand Up @@ -679,14 +684,25 @@ def test_classification_model(model_fn, dev):
pytest.skip("Skipped to reduce memory usage. Set env var SKIP_BIG_MODEL=0 to enable test for this model")
kwargs = {**defaults, **_model_params.get(model_name, {})}
num_classes = kwargs.get("num_classes")
num_expect = kwargs.pop("num_expect", num_classes)
input_shape = kwargs.pop("input_shape")
real_image = kwargs.pop("real_image", False)

model = model_fn(**kwargs)
pretrained_weight = kwargs.pop("pretrained_weight", False)
if not pretrained_weight:
model = model_fn(**kwargs)
else:
model = model_fn(**kwargs, weights="DEFAULT")
model.eval().to(device=dev)
x = _get_image(input_shape=input_shape, real_image=real_image, device=dev)
out = model(x)
_assert_expected(out.cpu(), model_name, prec=1e-3)
if num_expect != num_classes:
print(f"out.shape: {out.flatten().shape}")
expect_out = torch.nn.functional.pad(out.flatten(), (0, out.flatten().size(0) % num_expect))
expect_out = expect_out.view(num_expect, -1).flatten(start_dim=1).sum(dim=1)
else:
expect_out = out

_assert_expected(expect_out.cpu(), model_name, prec=1e-3)
assert out.shape[-1] == num_classes
_check_jit_scriptable(model, (x,), unwrapper=script_model_unwrapper.get(model_name, None), eager_out=out)
_check_fx_compatible(model, x, eager_out=out)
Expand Down