Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core ATen Opset] Lower aten_tan #5902

Closed
wonjoolee95 opened this issue Nov 21, 2023 · 0 comments · Fixed by #5915
Closed

[Core ATen Opset] Lower aten_tan #5902

wonjoolee95 opened this issue Nov 21, 2023 · 0 comments · Fixed by #5915
Assignees
Labels

Comments

@wonjoolee95
Copy link
Collaborator

In order for PyTorch/XLA to support the PyTorch core ATen opset, it requires lowering each core ATen op in PyTorch/XLA. This issue is used to track the PyTorch/XLA lowering for aten_tan.

Here are some general guidelines to lowering this op:

  • Uncomment @unittest.skip or @unittest.expectFailure and run the unit test at test_core_aten_ops.py. Eg: pytest test/test_core_aten_ops.py -k test_aten_tan_0
  • Make code changes until the test passes. Read and follow fix_lowering_for_core_aten_ops.md for ideas to fix.
    • There may be multiple unit tests for a single op. For this op, the corresponding unit tests are:
      • test_aten_tan_1
    • Please also uncomment the skips for all these tests and ensure all tests are fixed.
    • Note that sometimes the fix may be to fix the unit tests itself. Please take a look at the corresponding unit tests to make sure the tests are valid.
  • Submit the PR!

For any questions, feel free to leave a comment in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants