Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace computing with delaying in the bilinear resampling #215

Open
mraspaud opened this issue Sep 12, 2019 · 1 comment
Open

Replace computing with delaying in the bilinear resampling #215

mraspaud opened this issue Sep 12, 2019 · 1 comment
Assignees

Comments

@mraspaud
Copy link
Member

I'm not sure I understand why this needs to be computed and would prefer if things didn't have to be, but to get this merged I am ok with it.

Originally posted by @djhoese in #212

@pnuu
Copy link
Member

pnuu commented Sep 13, 2019

The indices need to be computed for the slicing to work. With dask arrays the slicing result would have a shape of (y_slice.size, x_slice.size) when it should be (y_slice.size, ). The {y,x}_slize arrays are the same size as the target area. Also, the sliced data is still a dask array, so the slicing in self._slice_data()._slicer() is a lazy operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants