-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest API implementation for store #16
Comments
To help with onboarding, I wrote a bunch of tests during the holiday in an attempt to make the project follow the TDD approach.
|
This works as a start. |
it would be nice to see the tests you came up with |
Looks great, I'll love to see the tests too |
As mentioned, here's #17 the accompany pull request containing the tests. |
I observed that you are making use of the default django fieldfield. This isn't exactly a problem but thinking about where we would host this which would be heroku for now and since they do not allow file access, we would want to make use of a third party image hosting provider like cloudinary. Its free for up to 1g or so. @Olamyy |
https://github.com/cloudinary/pycloudinary You can create an account but ensure that the config is passed as an environmental variable |
Hi @gbozee and @teenoh , Have we agreed on the model fields for users and store items discussed #11 (comment) ?
My branch currently has the following fields setup for a product.
For the user models, I have
Can I go ahead with those?
The text was updated successfully, but these errors were encountered: