Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest API implementation for store #16

Open
Olamyy opened this issue Jan 4, 2018 · 7 comments
Open

Rest API implementation for store #16

Olamyy opened this issue Jan 4, 2018 · 7 comments

Comments

@Olamyy
Copy link

Olamyy commented Jan 4, 2018

Hi @gbozee and @teenoh , Have we agreed on the model fields for users and store items discussed #11 (comment) ?

My branch currently has the following fields setup for a product.

  • product_code
  • unit_price
  • image
  • details

For the user models, I have

  • username
  • email
  • as fields.

Can I go ahead with those?

@Olamyy
Copy link
Author

Olamyy commented Jan 4, 2018

To help with onboarding, I wrote a bunch of tests during the holiday in an attempt to make the project follow the TDD approach.
I'd push these tests as soon after work today.
@teenoh In the long run, the tests in two ways:

  • Provide a general idea of the api implementation structure.
  • Help with onboarding for new contributors.

@gbozee
Copy link

gbozee commented Jan 4, 2018

This works as a start.

@gbozee
Copy link

gbozee commented Jan 4, 2018

it would be nice to see the tests you came up with

@teenoh
Copy link

teenoh commented Jan 4, 2018

Looks great, I'll love to see the tests too

@Olamyy
Copy link
Author

Olamyy commented Jan 5, 2018

As mentioned, here's #17 the accompany pull request containing the tests.
Do review and let me know things I'd need to improve.

@gbozee
Copy link

gbozee commented Jan 21, 2018

I observed that you are making use of the default django fieldfield. This isn't exactly a problem but thinking about where we would host this which would be heroku for now and since they do not allow file access, we would want to make use of a third party image hosting provider like cloudinary. Its free for up to 1g or so. @Olamyy

@gbozee
Copy link

gbozee commented Jan 21, 2018

https://github.com/cloudinary/pycloudinary You can create an account but ensure that the config is passed as an environmental variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants