Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyup cant find a requirements.txt file when there are brackets in the name #369

Closed
agconti opened this issue Jan 14, 2020 · 5 comments
Closed
Assignees

Comments

@agconti
Copy link

agconti commented Jan 14, 2020

Problem

Pyup tells me in the dashboard that it can't find my requirements.txt file.

Context

I run an open source project called django-cookiecutter-rest. It's a project template for Django apps. Because of that, it uses bracketed template variables in the project's folder names. Pyupbot is unable to find my requirements.txt file at: {{cookiecutter.github_repository_name}}/requirements.txt.

Here's my .pyup.yml config:

update: all
pin: True
branch: master

requirements:
  - /{/{cookiecutter.github_repository_name/}/}/requirements.txt

schedule: "every day"
search: True
label_prs: update
assignees:
- agconti

I've tried a few ways to specify the file but none have worked yet:

  • /{/{cookiecutter.github_repository_name/}/}/requirements.txt
  • "{{cookiecutter.github_repository_name}}/requirements.txt"
  • {{cookiecutter.github_repository_name}}/requirements.txt

Thanks for your help!

@agconti
Copy link
Author

agconti commented Jan 14, 2020

Looks the same as #343

@agconti
Copy link
Author

agconti commented Apr 25, 2020

Hey @rafaelpivato any update on this?

@rafaelpivato
Copy link
Contributor

@agconti thanks for the follow up!

My understanding is that we will be tackling this with our next release this week or next at most. We are happy that a cookiecutter project like https://github.com/agconti/cookiecutter-django-rest brings .pyup.yml bundled with it.

@rafaelpivato rafaelpivato self-assigned this Apr 30, 2020
@rafaelpivato
Copy link
Contributor

@agconti a deployment was made to https://pyup.io/ using latest pyupio/pyup version. Such latest version includes a fix handling filenames with stuff like {. Before moving forward looking further deep into the code, I would like to make sure that was not all you needed to fix your issue here.

Can you share a feedback about this issue again with this latest updates?

@agconti
Copy link
Author

agconti commented May 4, 2020

@rafaelpivato this fixed my issue. Thank you!

@agconti agconti closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants