Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify so we use general options in interactive mode #335

Closed
KSchopmeyer opened this issue Sep 11, 2019 · 2 comments
Closed

Modify so we use general options in interactive mode #335

KSchopmeyer opened this issue Sep 11, 2019 · 2 comments

Comments

@KSchopmeyer
Copy link
Contributor

Modify startup and command setup so that we use the general options for connections (--server, etc. in interactive mode as well as at startup. This involves two changes.

i. Process all of the options to the cli method on all calls, not just the initial call.
2. Modify Pywbemcliserver class to do clean modification of parameters as well as init.
3. Modify the code in the cli function that processes commands in interactive mode so that it processes all input parameters to cli and sets them into the current context.

NOTE: The goal is to use general options only for the current command execution, not to make them the norm for succeeding commands in the interactive session.

@andy-maier
Copy link
Contributor

Just for information, here is the behavior documented in PR #306 that we agreed on:

  • in interactive mode, commands can get general options but they apply only to that one command and not to future commands.
  • in interactive mode, general options specified on a command overwrite the inherited general options from the command invocation. Conflicting options in the resulting effective set of general options are rejected.

@andy-maier
Copy link
Contributor

Will be addressed by PR #336.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants