-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lines in pretty for ending tags #4
Comments
That was actually intentional, to hide the end tags. The alternative would be to have multiple pretty print formats - the current compact being one of them |
Personally anticipated that the pretty print format would look more like xmllint's output. I understand it might be a tad harder to implement, but I think that is the "correct" pretty printed format. |
Like you say, it's a matter of personal preference.
My suggestion would be to implement more than one pretty print output to support both
Piotr
… On 5 Apr 2017, at 20:00, Lance Carlson ***@***.***> wrote:
Personally anticipated that the pretty print format would look more like xmllint's output. I understand it might be a tad harder to implement, but I think that is the "correct" pretty printed format.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
The closing tags all piled on top of each other is a bit weird... IMHO. I can't say I've seen anyone do that before with xml. :) (Lisp, totally :D) |
https://github.com/pzol/xml_writer/blob/master/src/xml_writer.rs#L101
Do you think that there should be a newline here at the end? Currently the ending tags are clumping at the end. This might introduce indentation issues though.
The text was updated successfully, but these errors were encountered: