Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lines in pretty for ending tags #4

Open
lancecarlson opened this issue Apr 4, 2017 · 4 comments
Open

New lines in pretty for ending tags #4

lancecarlson opened this issue Apr 4, 2017 · 4 comments

Comments

@lancecarlson
Copy link

https://github.com/pzol/xml_writer/blob/master/src/xml_writer.rs#L101

Do you think that there should be a newline here at the end? Currently the ending tags are clumping at the end. This might introduce indentation issues though.

@pzol
Copy link
Owner

pzol commented Apr 5, 2017

That was actually intentional, to hide the end tags.
The idea was to have less lines and a bit more readability.

The alternative would be to have multiple pretty print formats - the current compact being one of them

@lancecarlson
Copy link
Author

Personally anticipated that the pretty print format would look more like xmllint's output. I understand it might be a tad harder to implement, but I think that is the "correct" pretty printed format.

@pzol
Copy link
Owner

pzol commented Apr 5, 2017 via email

@lholden
Copy link

lholden commented May 5, 2017

The closing tags all piled on top of each other is a bit weird... IMHO. I can't say I've seen anyone do that before with xml. :) (Lisp, totally :D)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants