Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the polyfill causes error with ember-concurrency but ember 3.6 beta does not #4

Closed
josemarluedke opened this issue Nov 21, 2018 · 2 comments

Comments

@josemarluedke
Copy link

Here is the reproduction: https://github.com/josemarluedke/--native-class-concurrency

When using this polyfill with ember-concurrency, it produces the error below, but if I run the same code with Ember v3.6.0-beta.4, it does not error out.

Class constructor ComputedProperty cannot be invoked without 'new'

My understanding is that we should avoid calling new on ember objects, which ember-concurrency does, so the error from the polyfill seem to be right, but I don't get why running in Ember wound not cause the error.

https://github.com/machty/ember-concurrency/blob/master/addon/index.js#L54

@rwjblue
Copy link

rwjblue commented Nov 21, 2018

This issue is here:

https://github.com/machty/ember-concurrency/blob/af891b292428ad4a789c1e172a1293119d42f4d9/addon/-task-property.js#L418

It should probably be rewritten as class TaskProperty extends ComputedProperty{}...

@buschtoens
Copy link

Tracked and fixed upstream in machty/ember-concurrency#261. 🚀

@pzuraq pzuraq closed this as completed Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants