refactor(scripts): move executors from monorepo to proper domain (microsoft#26345)

Author: Hotell

package.json

@@ -17,13 +17,13 @@
     "buildci": "lage build test lint type-check --verbose",
     "builddemo": "yarn build --to public-docsite-resources",
     "buildto": "lage build --verbose --to",
-    "buildto:lerna": "node ./scripts/monorepo/src/buildTo.js",
+    "buildto:lerna": "node ./scripts/executors/buildTo.js",
     "bundle": "lage bundle --verbose",
     "bundlesizecollect": "node ./scripts/generators/bundle-size-collect",
     "change": "beachball change --no-commit",
     "check:change": "beachball check",
     "check:modified-files": "node -r ./scripts/ts-node/register ./scripts/executors/check-for-modified-files",
-    "check:affected-package": "node ./scripts/monorepo/src/checkIfPackagesAffected.js",
+    "check:affected-package": "node ./scripts/executors/checkIfPackagesAffected.js",
     "check:installed-dependencies-versions": "satisfied --skip-invalid --ignore \"prettier|angular|lit|sass|@storybook/html|@storybook/mdx2-csf|svelte|@testing-library|vue|@cypress/react|cypress|@swc/wasm|@cactuslab/usepubsub|react-vis|@microsoft/load-themed-styles\"",
     "clean": "lage clean --verbose",
     "code-style": "lage code-style --verbose",
@@ -50,8 +50,8 @@
     "release:fluentui:patch": "node -r ./scripts/ts-node/register ./scripts/fluentui-publish publish-patch",
     "release:fluentui:post-validation": "node -r ./scripts/ts-node/register ./scripts/fluentui-publish post-publish",
     "rename-package": "node -r ./scripts/ts-node/register ./scripts/generators/rename-package.ts",
-    "run:published": "node ./scripts/monorepo/src/runPublished.js",
-    "runto:lerna": "node ./scripts/monorepo/src/runTo.js",
+    "run:published": "node ./scripts/executors/runPublished.js",
+    "runto:lerna": "node ./scripts/executors/runTo.js",
     "scrub": "node ./scripts/executors/scrub.js",
     "start": "node ./scripts/executors/start.js",
     "start:northstar": "yarn workspace @fluentui/docs start",

scripts/executors/buildTo.js

@@ -0,0 +1,31 @@
+const { runTo } = require('./runTo');
+
+const isExecutedFromCli = require.main === module;
+
+function main() {
+  const argv = process.argv.slice(2);
+
+  // Display a usage message when there are no projects specified
+  if (argv.length < 1) {
+    console.log(`Usage:
+
+  yarn buildto <packagename1> [<packagename2> ...] [<args>]
+
+This command builds all packages up to and including "packagename1" (and "packagename2" etc).
+The package name can be a substring.
+If multiple packages match a pattern, they will all be built (along with their dependencies).
+`);
+
+    process.exit(0);
+  }
+
+  const restIndex = argv.findIndex(arg => arg.startsWith('--'));
+  const projects = restIndex === -1 ? argv : argv.slice(0, restIndex);
+  const rest = restIndex === -1 ? [] : argv.slice(argv[restIndex] === '--' ? restIndex + 1 : restIndex);
+
+  runTo('build', projects, rest);
+}
+
+if (isExecutedFromCli) {
+  main();
+}

scripts/monorepo/src/checkIfPackagesAffected.js scripts/executors/checkIfPackagesAffected.js

@@ -1,5 +1,4 @@
-const getAffectedPackages = require('./getAffectedPackages');
-const getNthCommit = require('./getNthCommit');
+const { getAffectedPackages, getNthCommit } = require('@fluentui/scripts-monorepo');
 const yargs = require('yargs');
 
 const args = yargs
@@ -39,8 +38,12 @@ const isPackageAffected = () => {
   return false;
 };
 
-/**
- * In order for pipeline to capture and save the return value from a node script,
- * the output needs to be printed.
- */
-console.log(isPackageAffected());
+function main() {
+  /**
+   * In order for pipeline to capture and save the return value from a node script,
+   * the output needs to be printed.
+   */
+  console.log(isPackageAffected());
+}
+
+main();

scripts/monorepo/src/runPublished.js scripts/executors/runPublished.js

@@ -1,6 +1,6 @@
 const { spawnSync } = require('child_process');
-const getAllPackageInfo = require('./getAllPackageInfo');
-const isConvergedPackage = require('./isConvergedPackage');
+
+const { getAllPackageInfo, isConvergedPackage } = require('@fluentui/scripts-monorepo');
 const lageBin = require.resolve('lage/bin/lage.js');
 
 /**

scripts/monorepo/src/runPublished.spec.ts scripts/executors/runPublished.spec.ts

@@ -1,37 +1,16 @@
 const { spawnSync } = require('child_process');
 const lernaBin = require.resolve('lerna/cli.js');
-const getAllPackageInfo = require('./getAllPackageInfo');
 const os = require('os');
 
-const argv = process.argv.slice(2);
+const { getAllPackageInfo } = require('@fluentui/scripts-monorepo');
 
-if (require.main === module) {
-  // Display a usage message when there are no projects specified
-  if (argv.length < 2) {
-    console.log(`Usage:
-
-  yarn runto <script> <packagename1> [<packagename2> ...] [<args>]
-
-This command runs <script> for all packages up to and including "packagename1" (and "packagename2" etc).
-The package name can be a substring.
-If multiple packages match a pattern, they will all be built (along with their dependencies).
-`);
-
-    process.exit(0);
-  }
-
-  const restIndex = argv.findIndex(arg => arg.startsWith('--'));
-  const script = argv[0];
-  const projects = restIndex === -1 ? argv.slice(1) : argv.slice(1, restIndex);
-  const rest = restIndex === -1 ? [] : argv.slice(argv[restIndex] === '--' ? restIndex + 1 : restIndex);
-
-  runTo(script, projects, rest);
-}
+const isExecutedFromCli = require.main === module;
 
 /**
  * @param {string} script - Script to run
  * @param {string[]} projects - Projects to run in
  * @param {string[]} rest - Args to pass on
+ * @returns {void}
  */
 function runTo(script, projects, rest) {
   // This script matches substrings of the input for one more many projects
@@ -91,4 +70,32 @@ function runTo(script, projects, rest) {
   }
 }
 
-module.exports = runTo;
+function main() {
+  const argv = process.argv.slice(2);
+  // Display a usage message when there are no projects specified
+  if (argv.length < 2) {
+    console.log(`Usage:
+
+  yarn runto <script> <packagename1> [<packagename2> ...] [<args>]
+
+This command runs <script> for all packages up to and including "packagename1" (and "packagename2" etc).
+The package name can be a substring.
+If multiple packages match a pattern, they will all be built (along with their dependencies).
+`);
+
+    process.exit(0);
+  }
+
+  const restIndex = argv.findIndex(arg => arg.startsWith('--'));
+  const script = argv[0];
+  const projects = restIndex === -1 ? argv.slice(1) : argv.slice(1, restIndex);
+  const rest = restIndex === -1 ? [] : argv.slice(argv[restIndex] === '--' ? restIndex + 1 : restIndex);
+
+  runTo(script, projects, rest);
+}
+
+if (isExecutedFromCli) {
+  main();
+}
+
+exports.runTo = runTo;

scripts/monorepo/src/runTo.js scripts/executors/runTo.js

@@ -1,4 +1,5 @@
 const { spawnSync } = require('child_process');
+
 const findGitRoot = require('./findGitRoot');
 
 /**
@@ -27,4 +28,4 @@ function getAffectedPackages(since = 'origin/master') {
   return new Set(info.scope);
 }
 
-module.exports = getAffectedPackages;
+exports.getAffectedPackages = getAffectedPackages;

scripts/monorepo/src/buildTo.js

@@ -1,4 +1,4 @@
-const execSync = require('child_process').execSync;
+const { execSync } = require('child_process');
 
 /**
  * Returns SHA for the nth commit from a reference descending from the latest commit
@@ -12,4 +12,4 @@ function getNthCommit(n = 1, ref = 'HEAD') {
   return commitSha;
 }
 
-module.exports = getNthCommit;
+exports.getNthCommit = getNthCommit;

scripts/monorepo/src/getAffectedPackages.js

@@ -4,8 +4,9 @@ export { default as findGitRoot } from './findGitRoot';
 export { default as findRepoDeps } from './findRepoDeps';
 export { default as getAllPackageInfo } from './getAllPackageInfo';
 export { default as isConvergedPackage } from './isConvergedPackage';
-export { default as getAffectedPackages } from './getAffectedPackages';
+export { getAffectedPackages } from './getAffectedPackages';
 export { getLernaAliases } from './get-lerna-aliases';
 export { getDefaultEnvironmentVars } from './getDefaultEnvironmentVars';
 export { getProjectMetadata, workspaceRoot } from './utils';
 export * as eslintConstants from './eslint-constants';
+export { getNthCommit } from './getNthCommit';

scripts/monorepo/src/getNthCommit.js

@@ -4,8 +4,9 @@ module.exports = {
   findRepoDeps: require('./findRepoDeps'),
   getAllPackageInfo: require('./getAllPackageInfo'),
   isConvergedPackage: require('./isConvergedPackage'),
-  getAffectedPackages: require('./getAffectedPackages'),
   eslintConstants: require('./eslint-constants'),
+  ...require('./getAffectedPackages'),
+  ...require('./getNthCommit'),
   ...require('./getDefaultEnvironmentVars'),
   ...require('./get-lerna-aliases'),
   ...require('./utils'),