Testsuite doesn't check regressions

[dolmen]

The testsuite uses almost only t.Log instead of validating assertions and failing with t.Error, t.Fatal or t.Fail:

$ grep -E -c 'Error|Fatal|Fail|panic' *_test.go
excelize_test.go:3
sheet_test.go:0

This means that only code coverage is verified, but regressions are not checked automatically (humans have to read the go test -v output and have to know what is expected: that's not helpful for external contributors).

[dolmen]

It seems that most if err != nil blocks in *_test.go files that call t.Log could call t.Fatal instead.

Before:

if err  != nil {
    t.Log(err)
}

After:

if err  != nil {
    t.Fatal(err)
}

[dolmen]

@xuri Would you accept a patch that fixes this issue in the way I suggest in previous comment?

[xuri]

This is a late reply, this issue resolved by #322.