Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a run id for NGS measurement metadata #787

Open
1 task done
oquendoM opened this issue Aug 15, 2024 · 8 comments
Open
1 task done

Provide a run id for NGS measurement metadata #787

oquendoM opened this issue Aug 15, 2024 · 8 comments
Assignees
Labels
core Feature or fix task considered to be in the core product enhancement New feature or request

Comments

@oquendoM
Copy link

What are you missing?

Add the upload date to the downloaded metadata.

Why do you need a solution?

Sometimes users want to know which measurements were sequenced together (= uploaded together). This information is already depicted on the browser, but is not visible if you download the measurement metadata.

Ideas

Ideally the column would show only the date and exclude the time (ex. show 2024-07-24, instead of 2024-07-24 09:56). This makes filtering in excel possible.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@oquendoM oquendoM added enhancement New feature or request triage An issue that is in discussion to be either scheduled for implepmentation or denied labels Aug 15, 2024
@sven1103
Copy link
Contributor

sven1103 commented Aug 19, 2024

Dear @oquendoM ,

Sometimes users want to know which measurements were sequenced together (= uploaded together).

I think this assumption cannot be done based on the registration date of the measurement. I would also argue, that the date of the measurement itself (the real run in the lab) is not sufficient.

Why is this of relevance to the user, can you explain?

I imagine to provide another metadata property, that is explicit.

@sven1103 sven1103 added the needs clarification Unclear issue where more information needs to be provided by the issuer label Aug 19, 2024
@oquendoM
Copy link
Author

Hi,

The information is used to download only samples from a specific sequencing batch, which often correspond to the upload date from the lab. It is also important to know which samples are in which batch to look for sequencing batch effect during the analysis.

Best, Morgana

@sven1103
Copy link
Contributor

Hi @oquendoM ,

since we have the batch information, would it not make sense to have that information annotated upon measurement metadata export? We already provide the sample id and sample name, would just be another property.

What do you think?

Best, Sven

@oquendoM
Copy link
Author

Unfortunately sequencing batch and delivered batch (this one normally matches the metadata submission by the user) does not always match. The upload date would still be more informative in my opinion. But the complain of the impossibility to easily match sample metadata to the "raw data" metadata is a complain I heard already from the qPortal. This is normally relevant for big projects (>100 samples).

@sven1103
Copy link
Contributor

hm, but then I doubt the use of the batch property at all. We might need to differentiate between submission batch and measurement batch.

This can e.g. be realised, by providing an additional property for measurements. Like Measurement Run or sth alike?

@oquendoM
Copy link
Author

Yes something like a run ID. Would this need to be added to the measurement metadata manually?

@sven1103
Copy link
Contributor

Would this need to be added to the measurement metadata manually?

yes, we would introduce a property for measurements :)

@sven1103 sven1103 changed the title Add Date to downloaded Measurement Metadata Provide a run id for NGS measurement metadata Aug 27, 2024
@sven1103
Copy link
Contributor

I take this into planning, let's name the property run ID for now. Only NGS atm, I have not yet received any requirement for proteomics.

@sven1103 sven1103 added core Feature or fix task considered to be in the core product and removed triage An issue that is in discussion to be either scheduled for implepmentation or denied needs clarification Unclear issue where more information needs to be provided by the issuer labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Feature or fix task considered to be in the core product enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants