Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot failed to detect pr updating tinyspline #30

Open
madebr opened this issue Nov 22, 2020 · 3 comments
Open

Bot failed to detect pr updating tinyspline #30

madebr opened this issue Nov 22, 2020 · 3 comments

Comments

@madebr
Copy link
Contributor

madebr commented Nov 22, 2020

I opened a pr updating tinyspline yesterday at conan-io/conan-center-index#3639.
The bot has not picked up that pr the day after.
Running conan-center-bot status also marks tinyspline as not updated:

| tinyspline         | 0.2.0          | 0.3.0       | v0.3.0                 | 0          |

Maybe this is because tinyspline changed its method of tagging releases?
0.2.0 was tagged as 0.2.0 and 0.3.0 as v0.3.0.

@qchateau
Copy link
Owner

The issue is that both the PR title and body refer to the upgrade as "0.3" instead "0.3.0", which is the string CCB is looking for.

Checking the actual PR content would require cloning and the repo and analyzing the diff (for every opened PR), which I think is both overly complicated and time consuking.

@madebr
Copy link
Contributor Author

madebr commented Nov 22, 2020

Ah thanks, I didn't know how you detected these things.

@ericLemanissier
Copy link
Contributor

There a "lighter" way to do it: you can download the diff of a PR by using the diff_url property. This does not consume GH API credits,. You can then use https://github.com/matiasb/python-unidiff to analyse the change to conandata.yml files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants