Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add option to force container re-create rather than restart #16

Closed
oester opened this issue Nov 10, 2021 · 1 comment
Closed

Comments

@oester
Copy link

oester commented Nov 10, 2021

If you have a service configured similar to the following:

network_mode: "container:gluetun"
    healthcheck:
      test: "curl -sf https://google.com  || exit 1"
      interval: 1m
      timeout: 10s
      retries: 1
    labels:
      - deunhealth.restart.on.unhealthy=true

And the gluetun container is re-created due to a new version, the using container is marked as "unhealthy" but a container restart won't work because the container ID of the gluetun container is changed.

Consider adding an option "deunhealth.recreate.on.unhealthy=true" to resolve this.

@qdm12
Copy link
Owner

qdm12 commented Nov 11, 2021

It's a bit more complicated than that, but yes this is in progress 😉 This duplicates #11.

You might want to subscribe/read the bottom comments on #11 feel free to give your input too!

@qdm12 qdm12 closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants