Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appProtocol support #304

Open
the-mousaillon opened this issue Feb 20, 2025 · 0 comments
Open

Add appProtocol support #304

the-mousaillon opened this issue Feb 20, 2025 · 0 comments

Comments

@the-mousaillon
Copy link

Request:

Currently qdrant hem chart does not seem to support the appProtocol specification for the service.
Why ? Because it's the only way i got gRPC to work on gke, by setting the appProtocol of the grpc port to HTTP2

Solution i'd like

I would like to specify the appProtocol in the values.yaml

Example:

service:
  type: ClusterIP
  additionalLabels: {}
  annotations: {}
  loadBalancerIP: ""
  ports:
    - name: http
      port: 6333
      targetPort: 6333
      protocol: TCP
      appProtocol: HTTPS
      checksEnabled: true

    - name: grpc
      port: 6334
      targetPort: 6334
      protocol: TCP
      appProtocol: HTTP2
      checksEnabled: false

    - name: p2p
      port: 6335
      targetPort: 6335
      protocol: TCP
      checksEnabled: false

It should be quite simple to add
ex: for the service-headless:

apiVersion: v1
kind: Service
metadata:
  name: {{ include "qdrant.fullname" . }}-headless
  labels:
    {{- include "qdrant.labels" . | nindent 4 }}
    app.kubernetes.io/component: cluster-discovery
{{- with .Values.service.additionalLabels }}
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
  clusterIP: None
  publishNotReadyAddresses: true
  ports:
    {{- range .Values.service.ports }}
    - name: {{ .name }}
      port: {{ .port }}
      targetPort: {{ .targetPort }}
      protocol: {{ .protocol | default "TCP" }}
      {{- if .appProtocol }}
      appProtocol: {{ .appProtocol }}
      {{- end }}
    {{- end }}
  selector:
    {{- include "qdrant.selectorLabels" . | nindent 4 }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant