Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use delete_client wherever required #92

Open
KShivendu opened this issue Jan 15, 2024 · 1 comment
Open

Use delete_client wherever required #92

KShivendu opened this issue Jan 15, 2024 · 1 comment

Comments

@KShivendu
Copy link
Member

KShivendu commented Jan 15, 2024

We recently introduced delete_client in the base client classes for adding pgvector in #91. We need to check if there are other places where this can help.

e.g. replace closable classes of OpenSearch and elastic with delete_client functionality (and check if it works fine)

@LukasWestholt
Copy link

LukasWestholt commented Sep 16, 2024

Shouldn't the method also be called in the case of __del__?

So for example client.py:

class BaseClient:
    def __del__(self):
        self.delete_client()

Or at least in the try...catch block of run.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants