New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer activity timer #1419

Closed

kamilsa opened this issue Nov 22, 2022 · 2 comments

Assignees

Contributor

kamilsa commented Nov 22, 2022 •

edited

Loading

Timer of peer's activity is not updated, need to fix that to keep alive only peers that are active

kamilsa assigned turuslan

Contributor

turuslan commented Nov 22, 2022

https://github.com/soramitsu/kagome/blob/a635da383e5e59f6dec407d0eaf7b7a1e6bf2fc9/core/network/impl/peer_manager_impl.cpp#L294-L323
https://github.com/soramitsu/kagome/blob/a635da383e5e59f6dec407d0eaf7b7a1e6bf2fc9/core/network/impl/peer_manager_impl.cpp#L446-L451
https://github.com/soramitsu/kagome/blob/a635da383e5e59f6dec407d0eaf7b7a1e6bf2fc9/core/network/impl/peer_manager_impl.cpp#L478-L497

Contributor

turuslan commented Nov 24, 2022

Need to deduplicate/merge active_peers_ and peer_states_
https://github.com/soramitsu/kagome/blob/a635da383e5e59f6dec407d0eaf7b7a1e6bf2fc9/core/network/peer_manager.hpp#L44-L45
https://github.com/soramitsu/kagome/blob/a635da383e5e59f6dec407d0eaf7b7a1e6bf2fc9/core/network/impl/peer_manager_impl.hpp#L48-L49
https://github.com/soramitsu/kagome/blob/a635da383e5e59f6dec407d0eaf7b7a1e6bf2fc9/core/network/impl/peer_manager_impl.hpp#L189-L190

turuslan mentioned this issue

Disable peer disconnect on activity timeout #1424

Merged

kamilsa moved this from Selected for development to Todo in KAGOME

kamilsa closed this as completed

github-project-automation bot moved this from Todo to Done in KAGOME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment