Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] libp2p objects thread safety #2023

Closed
turuslan opened this issue Apr 1, 2024 · 0 comments
Closed

[Enhancement] libp2p objects thread safety #2023

turuslan opened this issue Apr 1, 2024 · 0 comments
Assignees
@turuslan
Labels
enhancement Multithreading Networking
Milestone
Polkadot treasury...

Comments

@turuslan
Copy link
Contributor

turuslan commented Apr 1, 2024 •
edited
Loading

Currently libp2p assumes single thread of execution and doesn't use mutexes.
Accessing libp2p objects from multiple threads will cause races.
Access libp2p objects from libp2p thread, or add mutexes or thread switches to libp2p.

  • GrandpaImpl::fallback_timer_handle_
@kamilsa kamilsa added this to the Polkadot treasury milestone 2 milestone Apr 3, 2024
@kamilsa kamilsa changed the title libp2p objects thread safety [Enhancement] libp2p objects thread safety Apr 4, 2024
This was referenced Apr 8, 2024
Closed
Merged
@turuslan turuslan mentioned this issue Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turuslan turuslan

Labels
enhancement Multithreading Networking
Projects
None yet
Milestone
Polkadot treasury milestone 2
Development

No branches or pull requests
2 participants
@kamilsa @turuslan