Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Empty blocks if not all validators validate parachains #2131

Closed
kamilsa opened this issue Jun 17, 2024 · 2 comments
Closed

[Bug]: Empty blocks if not all validators validate parachains #2131

kamilsa opened this issue Jun 17, 2024 · 2 comments
Labels
bug Something isn't working Networking Parachains

Comments

@kamilsa
Copy link
Contributor

kamilsa commented Jun 17, 2024

Bug Summary

Error occurs when number of parachain validators is less than number of all validators

Bug Description

It is observed that when KAGOME participates in parachains consensus in Kusama it creates blocks with no parachain inherents (Candidate backed/included).
The reason is that KAGOME implements Grid and cluster topologies, that distribute manifests only among parachain validators.
It is not clear how Polkadot-SDK validators create blocks with parachain inherents under the same circumstances

Steps to Reproduce

0001-parachains-pvf.toml.zip

  1. unpack
  2. run zombienet-macos-arm64 spawn -p native 0001-parachains-pvf.toml
  3. observe that KAGOME validator's blocks do not have parachain inherents

Effects of the Bug

Slow down in parachains block finalization as their manifests cannot be included in time

Expected Behavior

No response

System Information

Polkadot-SDK 1.13
KAGOME – latest master

Additional Context

No response

@kamilsa
Copy link
Contributor Author

kamilsa commented Aug 8, 2024

telegram-cloud-photo-size-4-5883196660069283128-y

@kamilsa
Copy link
Contributor Author

kamilsa commented Oct 3, 2024

implemented in #2180

@kamilsa kamilsa closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Networking Parachains
Projects
None yet
Development

No branches or pull requests

1 participant