[processing] Random points in polygons: fix NULL exp returning 1 #58815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When POINTS_NUMBER is set to an expression and the expression evaluation returns an invalid value, set the value to 0 instead of 1 (which is logically the min value for the fixed number option). Fixes qgis#58737
elpaso
added
Processing
|
It seems to me just changing: to numberPointsForThisFeature = mNumPointsProperty.valueAsInt( expressionContext, 0 );would fix the issue. |
nyalldawson
approved these changes
Sep 20, 2024
|
Wouldn't it be appropriate to backport to 3.34? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When POINTS_NUMBER is set to an expression and the expression evaluation returns an invalid value, set the value to 0 instead of 1 (which is logically the min value for the fixed number option).
Fix #58737