Improve qgsmessagelog caller information #60265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nifty |
benoitdm-oslandia
force-pushed
the
fix/qgsmessagelog
branch
from
f7a99bc to
ff95134
Compare
|
Looks good to me! |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
lbartoletti
reviewed
Jan 27, 2025
lbartoletti
reviewed
Jan 27, 2025
Co-authored-by: Loïc Bartoletti <lbartoletti@users.noreply.github.com>
benoitdm-oslandia
force-pushed
the
fix/qgsmessagelog
branch
from
e962488 to
5543111
Compare
lbartoletti
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QgsMessageLog::log calls
QgsDebugMsgLevelwhich display caller information based on the__FILE__,__FUNCTION__and__FILE__macros. This produce outputs like below where the caller information are lost:This PR makes use of
__builtin_FILE(),__builtin_FUNCTION()and__builtin_LINE()buildin c++ functions to retrieve the caller information to produce something like that: