Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

change email message when sample not logged #696

Merged
merged 1 commit into from
May 15, 2014

Conversation

teravest
Copy link
Contributor

fixes#695

We need to test this on webdev before merging. And we need Gail to verify IRB concerns.

@ElDeveloper
Copy link
Member

The message looks ok to me 👍

@teravest
Copy link
Contributor Author

it is on webdev now

On Tue, Apr 29, 2014 at 9:47 AM, Yoshiki Vázquez Baeza <
notifications@github.com> wrote:

The message looks ok to me [image: 👍]


Reply to this email directly or view it on GitHubhttps://github.com//pull/696#issuecomment-41693637
.

@adamrp
Copy link
Member

adamrp commented May 1, 2014

Can we merge this? Did @ackermag comment on whether or not a change to this text requires input from the IRB? I think it doesn't, but @rob-knight wanted to double check.

@ElDeveloper
Copy link
Member

Let's wait until we hear confirmation about this.

On Thu, May 01, 2014 at 02:29:00PM -0700, adamrp wrote:

Can we merge this? Did @ackermag comment on whether or not a change to this text requires input from the IRB? I think it doesn't, but @rob-knight wanted to double check.


Reply to this email directly or view it on GitHub:
#696 (comment)

@adamrp
Copy link
Member

adamrp commented May 5, 2014

@ackermag, we are just looking a yes or no on this one: does a change to this email require IRB approval?

This is the email that is sent out to participants when we receive a sample that has not been logged. As far as I know, it does not, but we needed confirmation before we can deploy this change.

@teravest
Copy link
Contributor Author

@ackermag Hey Gail, we are still waiting for a response from you to know if this email change requires IRB approval or if we can merge and deploy.

@ackermag
Copy link

Sorry Emily
I now realize I didn't tell you just Daniel - it does not require IRB
approval.

On Wed, May 14, 2014 at 10:43 AM, teravest notifications@github.com wrote:

@ackermag https://github.com/ackermag Hey Gail, we are still waiting
for a response from you to know if this email change requires IRB approval
or if we can merge and deploy.


Reply to this email directly or view it on GitHubhttps://github.com//pull/696#issuecomment-43105730
.

Gail Ackermann
Knight Lab UCB 596
University of Colorado
Boulder

@teravest
Copy link
Contributor Author

Thanks @ackermag we should be able to get this deployed tomorrow

On Wed, May 14, 2014 at 4:45 PM, ackermag notifications@github.com wrote:

Sorry Emily
I now realize I didn't tell you just Daniel - it does not require IRB
approval.

On Wed, May 14, 2014 at 10:43 AM, teravest notifications@github.com
wrote:

@ackermag https://github.com/ackermag Hey Gail, we are still waiting
for a response from you to know if this email change requires IRB
approval
or if we can merge and deploy.


Reply to this email directly or view it on GitHub<
https://github.com/qiime/qiime_web_app/pull/696#issuecomment-43105730>
.

Gail Ackermann
Knight Lab UCB 596
University of Colorado
Boulder


Reply to this email directly or view it on GitHubhttps://github.com//pull/696#issuecomment-43147536
.

@ElDeveloper
Copy link
Member

So merging then?

@teravest
Copy link
Contributor Author

please

On Thu, May 15, 2014 at 9:49 AM, Yoshiki Vázquez Baeza <
notifications@github.com> wrote:

So merging then?


Reply to this email directly or view it on GitHubhttps://github.com//pull/696#issuecomment-43227331
.

ElDeveloper added a commit that referenced this pull request May 15, 2014
change email message when sample not logged
@ElDeveloper ElDeveloper merged commit c4f5c59 into qiime:master May 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change email about missing sample info.
4 participants