New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

same barcode with different casing will be consider different #81

Open

antgonza opened this issue Jun 28, 2017 · 4 comments

Labels

type:bug

Member

antgonza commented Jun 28, 2017 •

edited by Mestabrook3

Loading

Current Behavior
AAAA and AaAA are different in the validator, and IMOO they should not

Member

jairideout commented Jun 28, 2017

Thanks @antgonza! What does validate_mapping_file.py do in this case?

Member Author

antgonza commented Jun 28, 2017

Not sure. @walterst, do you know?

walterst commented Jun 28, 2017

Hmm, I don't think they should be considered differently, the barcodes are forced into upper() when they are put into a list to be tested:
https://github.com/biocore/qiime/blob/master/qiime/check_id_map.py#L577
https://github.com/biocore/qiime/blob/master/qiime/check_id_map.py#L621
https://github.com/biocore/qiime/blob/master/qiime/check_id_map.py#L707

jairideout added the type:bug label

Member

jairideout commented Jul 6, 2017

Thanks for confirming @walterst! I agree that Keemei's validator should get updated to find duplicate barcodes in a case-insensitive manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment