Fix 2230 (#2372)

* fix calls to system_call and ebi submissions

* fixing errors

* fix if state == submitting:

* just raise error

* EBISubmissionError -> ComputeError

* Fix #2230 solved using modal in order to prevent large file download

* Function moved into in order to keep order. Some details fixed.

Author: danteese

qiita_pet/templates/sitebase.html

@@ -235,6 +235,12 @@
           });
         });
 
+        $('#qiita_download_accept').click(function(e){
+          e.preventDefault();
+          $('.qiita_pet_download_confirm').modal('hide');
+          window.location.href = '{% raw qiita_config.portal_dir %}/release/download/public';
+        });
+
         // Based on http://codepen.io/willvincent/pen/LbeKKW
         //    and   https://datatables.net/examples/api/row_details.html
 
@@ -555,11 +561,11 @@ <h6>
                 <a href="#" data-toggle="dropdown" class="dropdown-toggle">Downloads<b class="caret"></b></a>
                 <ul class="dropdown-menu">
                   <li>
-                    <a href="{% raw qiita_config.portal_dir %}/release/download/public">
+                    <a type="button" data-toggle="modal" data-target=".qiita_pet_download_confirm">
                       Public BIOM and metadata files
                       <small>
                         <br/><b>MD5:</b> {{public_md5}}
-                        <br/><b>Last update:</b>{{public_timestamp}}
+                        <br/><b>Last update:</b> {{public_timestamp}}
                       </small>
                     </a>
                   </li>
@@ -570,6 +576,24 @@ <h6>
         </div>
       </div> <!--/.main nav-bar -->
 
+      <div class="modal fade qiita_pet_download_confirm" tabindex="-1" role="dialog" aria-labelledby="Confirm download">
+        <div class="modal-dialog modal-lg" role="document">
+          <div class="modal-content">
+            <div class="modal-header">
+              <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button>
+              <h4 class="modal-title">File really big.</h4>
+            </div>
+            <div class="modal-body">
+              <p>The file you're trying to download is really big. Would you like to proceed?</p>
+            </div>
+            <div class="modal-footer">
+              <button type="button" class="btn btn-danger" data-dismiss="modal">No</button>
+              <button type="button" class="btn btn-success" id="qiita_download_accept">Yes</button>
+            </div>
+          </div>
+        </div>
+      </div>
+
 
       {% if message != '' %}
           {% if level not in {'danger', 'success', 'info', 'warning'} %}

qiita_pet/test/test_download.py

@@ -161,21 +161,6 @@ def test_download_study(self):
         response = self.get('/download_study_bioms/1')
         self.assertEqual(response.code, 200)
         exp = (
-            '- 1256812 /protected/processed_data/1_study_1001_closed_'
-            'reference_otu_table.biom processed_data/1_study_1001_closed_'
-            'reference_otu_table.biom\n'
-            '- 36615 /protected/templates/1_prep_1_qiime_[0-9]*-'
-            '[0-9]*.txt mapping_files/4_mapping_file.txt\n'
-            '- 1256812 /protected/processed_data/'
-            '1_study_1001_closed_reference_otu_table.biom processed_data/'
-            '1_study_1001_closed_reference_otu_table.biom\n'
-            '- 36615 /protected/templates/1_prep_1_qiime_[0-9]*-'
-            '[0-9]*.txt mapping_files/5_mapping_file.txt\n'
-            '- 1256812 /protected/processed_data/'
-            '1_study_1001_closed_reference_otu_table_Silva.biom processed_data'
-            '/1_study_1001_closed_reference_otu_table_Silva.biom\n'
-            '- 36615 /protected/templates/1_prep_1_qiime_[0-9]*-'
-            '[0-9]*.txt mapping_files/6_mapping_file.txt\n'
             '- [0-9]* /protected/BIOM/{0}/otu_table.biom '
             'BIOM/{0}/otu_table.biom\n'
             '- 1 /protected/BIOM/{0}/sortmerna_picked_otus/seqs_otus.log '