addressing all comments

Author: antgonza

qiita_db/test/test_user.py

@@ -450,14 +450,26 @@ def test_user_artifacts(self):
                                     qdb.artifact.Artifact(7)]}
         self.assertEqual(obs, exp)
 
-    def test_jobs(self):
+    def test_jobs_all(self):
         PJ = qdb.processing_job.ProcessingJob
+        ignore_status = []
         # generates expected jobs
-        jobs = qdb.user.User('shared@foo.bar').jobs()
+        jobs = qdb.user.User('shared@foo.bar').jobs(ignore_status)
         self.assertEqual(jobs, [
             PJ('d19f76ee-274e-4c1b-b3a2-a12d73507c55'),
             PJ('b72369f9-a886-4193-8d3d-f7b504168e75')])
 
+        # no jobs
+        self.assertEqual(qdb.user.User('admin@foo.bar').jobs(
+            ignore_status), [])
+
+    def test_jobs_defaults(self):
+        PJ = qdb.processing_job.ProcessingJob
+        # generates expected jobs
+        jobs = qdb.user.User('shared@foo.bar').jobs()
+        self.assertEqual(jobs, [
+            PJ('d19f76ee-274e-4c1b-b3a2-a12d73507c55')])
+
         # no jobs
         self.assertEqual(qdb.user.User('admin@foo.bar').jobs(), [])
 

qiita_db/user.py

@@ -661,23 +661,43 @@ def delete_messages(self, messages):
             qdb.sql_connection.TRN.add(sql)
             qdb.sql_connection.TRN.execute()
 
-    def jobs(self):
+    def jobs(self, ignore_status=['success']):
         """Return jobs created by the user
 
         Parameters
         ----------
+        ignore_status, list of str
+            don't retieve jobs that have one of these status
 
         Returns
         -------
         list of ProcessingJob
 
         """
         with qdb.sql_connection.TRN:
-            sql_info = [self._id]
             sql = """SELECT processing_job_id
                      FROM qiita.processing_job
+                     LEFT JOIN qiita.processing_job_status
+                        USING (processing_job_status_id)
                      WHERE email = %s
-                     ORDER BY heartbeat DESC"""
+                  """
+
+            if ignore_status:
+                sql_info = [self._id, tuple(ignore_status)]
+                sql += "    AND processing_job_status NOT IN %s"
+            else:
+                sql_info = [self._id]
+
+            sql += """
+                     ORDER BY CASE processing_job_status
+                            WHEN 'in_construction' THEN 1
+                            WHEN 'running' THEN 2
+                            WHEN 'queued' THEN 3
+                            WHEN 'waiting' THEN 4
+                            WHEN 'error' THEN 5
+                            WHEN 'success' THEN 6
+                        END, heartbeat DESC"""
+
             qdb.sql_connection.TRN.add(sql, sql_info)
             return [qdb.processing_job.ProcessingJob(p[0])
                     for p in qdb.sql_connection.TRN.execute_fetchindex()]

qiita_pet/handlers/api_proxy/tests/test_user.py

@@ -46,24 +46,8 @@ def test_user_jobs_get_req(self):
                     'threads': 1,
                     'sortmerna_coverage': 0.97},
                  'name': 'Pick closed-reference OTUs',
-                 'processing_job_workflow_id': ''},
-                {'id': 'b72369f9-a886-4193-8d3d-f7b504168e75',
-                 'status': 'success',
-                 'heartbeat': '2015-11-22 21:15:00',
-                 'params': {
-                    'max_barcode_errors': 1.5,
-                    'sequence_max_n': 0,
-                    'max_bad_run_length': 3,
-                    'phred_offset': u'auto',
-                    'rev_comp': False,
-                    'phred_quality_threshold': 3,
-                    'input_data': 1,
-                    'rev_comp_barcode': False,
-                    'rev_comp_mapping_barcodes': True,
-                    'min_per_read_length_fraction': 0.75,
-                    'barcode_type': u'golay_12'},
-                 'name': 'Split libraries FASTQ',
-                 'processing_job_workflow_id': 1}]}
+                 'step': 'generating demux file',
+                 'processing_job_workflow_id': ''}]}
         self.assertEqual(obs, exp)
 
 

qiita_pet/handlers/api_proxy/user.py

@@ -11,7 +11,7 @@
 
 
 @execute_as_transaction
-def user_jobs_get_req(user, limit=10):
+def user_jobs_get_req(user, limit=30):
     """Gets the json of jobs
 
     Parameters
@@ -42,6 +42,7 @@ def user_jobs_get_req(user, limit=10):
             'params': j.parameters.values,
             'status': j.status,
             'heartbeat': hb,
+            'step': j.step,
             'processing_job_workflow_id': wid})
 
     return {'status': 'success',

qiita_pet/static/css/style.css

@@ -1,23 +1,29 @@
-div.qiita-main {
+#qiita-main {
   position: relative;
   height: 100%;
   width: 100%;
 }
-
 #qiita-processing {
   position: absolute;
   height: 100%;
   width: 0%;
   right: 0;
   top: 0;
 }
-
 #template-content{
   padding: 10px;
   height: 100%;
   width: 100%;
 }
 
+td.more-info-processing-jobs{
+  cursor: pointer;
+  background: url('../img//details_open.png') no-repeat center center;
+}
+tr.shown td.more-info-processing-jobs {
+    background: url('../img//details_close.png') no-repeat center center;
+}
+
 /* table in the study description that holds the investigation type elements */
 .investigation-type-table td {
   padding-top: 6px;

qiita_pet/static/img/details_close.png

@@ -29,13 +29,46 @@ function bootstrapAlert(message, severity, timeout){
     alertDiv.append('<p style="text-align:center">Need help? Send us an <a href="mailto:qiita.help@gmail.com">email</a>.</p>');
   }
 
-  $('body').prepend(alertDiv);
+  $('#qiita-main').prepend(alertDiv);
 
   if(timeout > 0) {
    window.setTimeout(function() { $('#alert-message').alert('close'); }, timeout);
   }
 }
 
+function format_extra_info_processing_jobs ( data ) {
+    // `data` is the original data object for the row
+    // 0: blank +/- button
+    // 1: heartbeat
+    // 2: name
+    // 3: status
+    // 4: step
+    // 5: id
+    // 6: params
+    // 7: processing_job_workflow_id
+
+    let row = '<table cellpadding="5" cellspacing="0" border="0" style="padding-left:50px;">'+
+                '<tr>'+
+                    '<td><b>ID:</b></td>'+
+                    '<td>'+ data[5] +'</td>'+
+                '</tr>'+
+                '<tr>'+
+                    '<td colspan="2"><h5>Parameters:</h5>'+ data[6] +'</td>'+
+                '</tr>';
+    if (data[7] !== '') {
+      row += '<tr>'+
+                '<td colspan="2">'+
+                  '<button class="btn btn-danger btn-sm" onclick="remove_job(\''+ data[5] + "', '" + data[7] +'\');">'+
+                  '<span class="glyphicon glyphicon-trash"></span></button>'+
+                '</td>'
+             '</tr>';
+    }
+    row += '</table>';
+
+    return row
+}
+
+
 function show_hide(div) {
 	$('#' + div).toggle();
 }
@@ -60,6 +93,8 @@ function delete_analysis(aname, analysis_id) {
 
 function show_hide_process_list() {
   if ($("#qiita-main").width() == $("#qiita-main").parent().width()) {
+    // let's update the job list
+    processing_jobs_vue.update_processing_job_data();
     $("#qiita-main").width("76%");
     $("#user-studies-table").width("76%");
     $("#studies-table").width("76%");

qiita_pet/static/img/details_open.png

@@ -5,12 +5,6 @@
 <link rel="stylesheet" href="{% raw qiita_config.portal_dir %}/static/vendor/css/select2.min.css" type="text/css">
 
 <style>
-#alert-message {
-  position: fixed;
-  top: 50px;
-  left: 40px;
-  z-index:100;
-}
 td.details-control {
   cursor: pointer;
 }

qiita_pet/static/js/qiita.js

@@ -10,13 +10,6 @@
   .portal-select {
     width: 15em;
   }
-  #alert-message {
-    position: fixed;
-    top: 55px;
-    left:30%;
-    z-index:100;
-    white-space: nowrap;
-  }
 </style>
 <script type="text/javascript">
 function check_submit(action) {