Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: provide file-level feedback #159

Open
CarlJi opened this issue Jun 12, 2024 · 1 comment
Open

proposal: provide file-level feedback #159

CarlJi opened this issue Jun 12, 2024 · 1 comment

Comments

@CarlJi
Copy link
Contributor

CarlJi commented Jun 12, 2024

The current feedback from Reviewbot is only at the contextual level of the diff code. This creates a possibility where, in order to fix one issue, a new diff is introduced, leading to new problems and making the PR author feel like the issues are never-ending.

Therefore, the plan is to provide file-level error feedback that can be enabled through configuration when needed.

The benefit of this approach is that it allows for the prompt resolution of lingering issues in the repository.

Furthermore, we can even provide repository-level error feedback in the future.

@CarlJi
Copy link
Contributor Author

CarlJi commented Jun 12, 2024

For file or repository-level issue feedback, since it is not within the context of a diff, GitHub likely does not support commenting directly within the code. Therefore, it could be considered to provide the feedback in the form of issue comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant